From: Russ Cox <rsc@golang.org>
Date: Fri, 20 Apr 2018 14:16:00 +0000 (-0400)
Subject: cmd/go: respect vet typecheck failures again
X-Git-Tag: go1.11beta1~671
X-Git-Url: http://www.git.cypherpunks.su/?a=commitdiff_plain;h=279b530d6822dd381c049f3c0b5a7ef677574e18;p=gostls13.git

cmd/go: respect vet typecheck failures again

Now that #18395 is fixed, let's see if we can insist
on vet during go test being able to type-check
packages again.

Change-Id: Iaa55a4d9c582ba743df2347d28c24f130e16e406
Reviewed-on: https://go-review.googlesource.com/108555
Run-TryBot: Russ Cox <rsc@golang.org>
Reviewed-by: Robert Griesemer <gri@golang.org>
---

diff --git a/src/cmd/go/internal/work/exec.go b/src/cmd/go/internal/work/exec.go
index 7014159cee..8f985bc0e3 100644
--- a/src/cmd/go/internal/work/exec.go
+++ b/src/cmd/go/internal/work/exec.go
@@ -720,7 +720,9 @@ func (b *Builder) vet(a *Action) error {
 	// so at least for now assume the bug is in vet.
 	// We know of at least #18395.
 	// TODO(rsc,gri): Try to remove this for Go 1.11.
-	vcfg.SucceedOnTypecheckFailure = cfg.CmdName == "test"
+	//
+	// Disabled 2018-04-20. Let's see if we can do without it.
+	// vcfg.SucceedOnTypecheckFailure = cfg.CmdName == "test"
 
 	js, err := json.MarshalIndent(vcfg, "", "\t")
 	if err != nil {