From: Alex Brainman Date: Wed, 8 Feb 2017 01:47:43 +0000 (+1100) Subject: cmd/link: write dwarf sections X-Git-Tag: go1.9beta1~1372 X-Git-Url: http://www.git.cypherpunks.su/?a=commitdiff_plain;h=29f061960d5008170541a886feab721bf754f0fd;p=gostls13.git cmd/link: write dwarf sections Also stop skipping TestExternalLinkerDWARF and TestDefaultLinkerDWARF. Fixes #10776. Change-Id: Ia596a684132e3cdee59ce5539293eedc1752fe5a Reviewed-on: https://go-review.googlesource.com/36983 Reviewed-by: Ian Lance Taylor --- diff --git a/src/cmd/link/internal/ld/dwarf.go b/src/cmd/link/internal/ld/dwarf.go index 22d2c548c3..696a80bcdc 100644 --- a/src/cmd/link/internal/ld/dwarf.go +++ b/src/cmd/link/internal/ld/dwarf.go @@ -1482,7 +1482,11 @@ func dwarfgeneratedebugsyms(ctxt *Link) { } if Linkmode == LinkExternal { - if !Iself && Headtype != obj.Hdarwin { + switch { + case Iself: + case Headtype == obj.Hdarwin: + case Headtype == obj.Hwindows: + default: return } } diff --git a/src/debug/pe/file_cgo_test.go b/src/debug/pe/file_cgo_test.go index d09890fb7e..739671d73f 100644 --- a/src/debug/pe/file_cgo_test.go +++ b/src/debug/pe/file_cgo_test.go @@ -19,7 +19,6 @@ func testCgoDWARF(t *testing.T, linktype int) { } func TestDefaultLinkerDWARF(t *testing.T) { - t.Skip("skipping broken test: see issue 10776") testCgoDWARF(t, linkCgoDefault) } @@ -28,6 +27,5 @@ func TestInternalLinkerDWARF(t *testing.T) { } func TestExternalLinkerDWARF(t *testing.T) { - t.Skip("skipping broken test: see issue 10776") testCgoDWARF(t, linkCgoExternal) }