From: Matthew Dempsky Date: Tue, 11 Apr 2017 05:16:43 +0000 (-0700) Subject: cmd/compile/internal/ssa: remove unused Typ fields X-Git-Tag: go1.9beta1~752 X-Git-Url: http://www.git.cypherpunks.su/?a=commitdiff_plain;h=2a8d99e427ab19cb4f00680244f31818b53aa238;p=gostls13.git cmd/compile/internal/ssa: remove unused Typ fields These are never accessed. Change-Id: I45975972d19d1f263f6545c9ed648511501094c6 Reviewed-on: https://go-review.googlesource.com/40315 Run-TryBot: Matthew Dempsky Reviewed-by: Brad Fitzpatrick TryBot-Result: Gobot Gobot --- diff --git a/src/cmd/compile/internal/gc/ssa.go b/src/cmd/compile/internal/gc/ssa.go index 75acaa3ebc..2e62ee32f4 100644 --- a/src/cmd/compile/internal/gc/ssa.go +++ b/src/cmd/compile/internal/gc/ssa.go @@ -157,7 +157,7 @@ func buildssa(fn *Node) *ssa.Func { for _, n := range fn.Func.Dcl { switch n.Class { case PPARAM, PPARAMOUT: - aux := s.lookupSymbol(n, &ssa.ArgSymbol{Typ: n.Type, Node: n}) + aux := s.lookupSymbol(n, &ssa.ArgSymbol{Node: n}) s.decladdrs[n] = s.entryNewValue1A(ssa.OpAddr, types.NewPtr(n.Type), aux, s.sp) if n.Class == PPARAMOUT && s.canSSA(n) { // Save ssa-able PPARAMOUT variables so we can @@ -3212,18 +3212,18 @@ func (s *state) addr(n *Node, bounded bool) *ssa.Value { } if n == nodfp { // Special arg that points to the frame pointer (Used by ORECOVER). - aux := s.lookupSymbol(n, &ssa.ArgSymbol{Typ: n.Type, Node: n}) + aux := s.lookupSymbol(n, &ssa.ArgSymbol{Node: n}) return s.entryNewValue1A(ssa.OpAddr, t, aux, s.sp) } s.Fatalf("addr of undeclared ONAME %v. declared: %v", n, s.decladdrs) return nil case PAUTO: - aux := s.lookupSymbol(n, &ssa.AutoSymbol{Typ: n.Type, Node: n}) + aux := s.lookupSymbol(n, &ssa.AutoSymbol{Node: n}) return s.newValue1A(ssa.OpAddr, t, aux, s.sp) case PPARAMOUT: // Same as PAUTO -- cannot generate LEA early. // ensure that we reuse symbols for out parameters so // that cse works on their addresses - aux := s.lookupSymbol(n, &ssa.ArgSymbol{Typ: n.Type, Node: n}) + aux := s.lookupSymbol(n, &ssa.ArgSymbol{Node: n}) return s.newValue1A(ssa.OpAddr, t, aux, s.sp) default: s.Fatalf("variable address class %v not implemented", classnames[n.Class]) diff --git a/src/cmd/compile/internal/ssa/value.go b/src/cmd/compile/internal/ssa/value.go index d5974d4eb2..1bc63bce5a 100644 --- a/src/cmd/compile/internal/ssa/value.go +++ b/src/cmd/compile/internal/ssa/value.go @@ -246,14 +246,12 @@ type ExternSymbol struct { // ArgSymbol is an aux value that encodes an argument or result // variable's constant offset from FP (FP = SP + framesize). type ArgSymbol struct { - Typ Type // Go type Node GCNode // A *gc.Node referring to the argument/result variable. } // AutoSymbol is an aux value that encodes a local variable's // constant offset from SP. type AutoSymbol struct { - Typ Type // Go type Node GCNode // A *gc.Node referring to a local (auto) variable. } diff --git a/src/cmd/compile/internal/ssa/writebarrier.go b/src/cmd/compile/internal/ssa/writebarrier.go index 1b6e51c674..e8e5a26f30 100644 --- a/src/cmd/compile/internal/ssa/writebarrier.go +++ b/src/cmd/compile/internal/ssa/writebarrier.go @@ -265,7 +265,7 @@ func wbcall(pos src.XPos, b *Block, fn *obj.LSym, typ interface{}, ptr, val, mem // value we're trying to move. t := val.Type.ElemType() tmp = b.Func.fe.Auto(val.Pos, t) - aux := &AutoSymbol{Typ: t, Node: tmp} + aux := &AutoSymbol{Node: tmp} mem = b.NewValue1A(pos, OpVarDef, TypeMem, tmp, mem) tmpaddr := b.NewValue1A(pos, OpAddr, t.PtrTo(), aux, sp) siz := t.Size()