From: David Symonds Date: Mon, 30 Jul 2012 04:41:04 +0000 (+1000) Subject: misc/dashboard/codereview: pass user information to gobot when assigning reviewer. X-Git-Tag: go1.1rc2~2746 X-Git-Url: http://www.git.cypherpunks.su/?a=commitdiff_plain;h=2a9478ed6446e2cbdef47d9dea1bd857c86631c1;p=gostls13.git misc/dashboard/codereview: pass user information to gobot when assigning reviewer. R=bradfitz CC=gobot, golang-dev, rsc https://golang.org/cl/6457052 --- diff --git a/misc/dashboard/codereview/dashboard/cl.go b/misc/dashboard/codereview/dashboard/cl.go index 8665947760..181d2e40fe 100644 --- a/misc/dashboard/codereview/dashboard/cl.go +++ b/misc/dashboard/codereview/dashboard/cl.go @@ -128,7 +128,8 @@ func handleAssign(w http.ResponseWriter, r *http.Request) { } u := user.Current(c) - if _, ok := emailToPerson[u.Email]; !ok { + person, ok := emailToPerson[u.Email] + if !ok { http.Error(w, "Not allowed", http.StatusUnauthorized) return } @@ -183,7 +184,7 @@ func handleAssign(w http.ResponseWriter, r *http.Request) { if !found { c.Infof("Adding %v as a reviewer of CL %v", rev, n) - url := fmt.Sprintf("%s?cl=%s&r=%s", gobotBase, n, rev) + url := fmt.Sprintf("%s?cl=%s&r=%s&obo=%s", gobotBase, n, rev, person) resp, err := urlfetch.Client(c).Get(url) if err != nil { c.Errorf("Gobot GET failed: %v", err)