From: Giovanni Bajo Date: Sat, 21 Mar 2020 12:22:14 +0000 (+0100) Subject: doc: decrease prominence of GOROOT_BOOTSTRAP X-Git-Tag: go1.15beta1~724 X-Git-Url: http://www.git.cypherpunks.su/?a=commitdiff_plain;h=2ba00e47545406b3dd11436e3f1acf841d4932c6;p=gostls13.git doc: decrease prominence of GOROOT_BOOTSTRAP Go build scripts on UNIX (make.bash, all.bash) have not required GOROOT_BOOTSTRAP since August 2017 (CL 57753). Windows build scripts have followed suit since CL 96455. Most people building Go will have a Go toolchain in their PATH and will not need to specify a different toolchain. This CL removes the GOROOT_BOOTSTRAP mention from the contribution guide (it was there for Windows only, but it's not required anymore). The guide is meant to be light and clear for beginners and is not supposed to be a reference, so there's not need to keep mentioning GOROOT_BOOTSTRAP. Also update install-source.html to reflect the current status quo, where using the PATH is probably the first and most used default, and GOROOT_BOOTSTRAP is just an option. Change-Id: Iab453e61b0c749c256aaaf81ea9b2ae58822cb89 Reviewed-on: https://go-review.googlesource.com/c/go/+/224717 Run-TryBot: Giovanni Bajo TryBot-Result: Gobot Gobot Reviewed-by: Rob Pike --- diff --git a/doc/contribute.html b/doc/contribute.html index 551d510288..4135d13652 100644 --- a/doc/contribute.html +++ b/doc/contribute.html @@ -552,9 +552,7 @@ $ ./all.bash

-(To build under Windows use all.bat; this also requires -setting the environment variable GOROOT_BOOTSTRAP to the -directory holding the Go tree for the bootstrap compiler.) +(To build under Windows use all.bat)

diff --git a/doc/install-source.html b/doc/install-source.html index 17b1c9cbb7..3d42a10ad6 100644 --- a/doc/install-source.html +++ b/doc/install-source.html @@ -106,23 +106,17 @@ Go does not support CentOS 6 on these systems. -

Install Go compiler binaries

+

Install Go compiler binaries for bootstrap

The Go toolchain is written in Go. To build it, you need a Go compiler installed. -The scripts that do the initial build of the tools look for an existing Go tool -chain in $GOROOT_BOOTSTRAP. -If unset, the default value of GOROOT_BOOTSTRAP -is $HOME/go1.4. -

- -

-There are many options for the bootstrap toolchain. -After obtaining one, set GOROOT_BOOTSTRAP to the -directory containing the unpacked tree. -For example, $GOROOT_BOOTSTRAP/bin/go should be -the go command binary for the bootstrap toolchain. -

+The scripts that do the initial build of the tools look for a "go" command +in $PATH, so as long as you have Go installed in your +system and configured in your $PATH, you are ready to build Go +from source. +Or if you prefer you can set $GOROOT_BOOTSTRAP to the +root of a Go installation to use to build the new Go toolchain; +$GOROOT_BOOTSTRAP/bin/go should be the go command to use.

Bootstrap toolchain from binary release