From: Russ Cox <rsc@golang.org>
Date: Tue, 14 Jul 2015 19:38:46 +0000 (-0400)
Subject: cmd/pprof: run $BROWSER and system browser before Chrome
X-Git-Tag: go1.5beta2~44
X-Git-Url: http://www.git.cypherpunks.su/?a=commitdiff_plain;h=2bd1e5e50b677790a2f48127bf443b32ca8193db;p=gostls13.git

cmd/pprof: run $BROWSER and system browser before Chrome

Fixes #10259.

Change-Id: Ica6b8301cc8291785a3c496fb513050813b2d8df
Reviewed-on: https://go-review.googlesource.com/12201
Reviewed-by: Andrew Gerrand <adg@golang.org>
---

diff --git a/src/cmd/pprof/internal/commands/commands.go b/src/cmd/pprof/internal/commands/commands.go
index 167e57f1f4..175c7cc99c 100644
--- a/src/cmd/pprof/internal/commands/commands.go
+++ b/src/cmd/pprof/internal/commands/commands.go
@@ -82,7 +82,10 @@ func PProf(c Completer, interactive **bool) Commands {
 // browsers returns a list of commands to attempt for web visualization
 // on the current platform
 func browsers() []string {
-	cmds := []string{"chrome", "google-chrome", "firefox"}
+	var cmds []string
+	if exe := os.Getenv("BROWSER"); exe != "" {
+		cmds = append(cmds, exe)
+	}
 	switch runtime.GOOS {
 	case "darwin":
 		cmds = append(cmds, "/usr/bin/open")
@@ -91,6 +94,7 @@ func browsers() []string {
 	default:
 		cmds = append(cmds, "xdg-open")
 	}
+	cmds = append(cmds, "chrome", "google-chrome", "firefox")
 	return cmds
 }