From: Matthew Dempsky <mdempsky@google.com>
Date: Fri, 1 Jul 2022 02:38:10 +0000 (-0700)
Subject: [dev.unified] cmd/compile/internal/reflectdata: prefer ITabAddrAt in ConvIfaceTypeWord
X-Git-Tag: go1.20rc1~1807^2~26
X-Git-Url: http://www.git.cypherpunks.su/?a=commitdiff_plain;h=2cf632cd57;p=gostls13.git

[dev.unified] cmd/compile/internal/reflectdata: prefer ITabAddrAt in ConvIfaceTypeWord

We already have an explicit `pos` parameter, so we should use
ITabAddrAt instead of ITabAddr (which uses `base.Pos` instead).

Change-Id: I7c8c5ae93d0ae7a6467cc972575cb547981576f0
Reviewed-on: https://go-review.googlesource.com/c/go/+/415578
Run-TryBot: Matthew Dempsky <mdempsky@google.com>
Reviewed-by: David Chase <drchase@google.com>
TryBot-Result: Gopher Robot <gobot@golang.org>
---

diff --git a/src/cmd/compile/internal/reflectdata/helpers.go b/src/cmd/compile/internal/reflectdata/helpers.go
index 03d1ae3dc2..81bb18788f 100644
--- a/src/cmd/compile/internal/reflectdata/helpers.go
+++ b/src/cmd/compile/internal/reflectdata/helpers.go
@@ -113,7 +113,7 @@ func ConvIfaceTypeWord(pos src.XPos, n *ir.ConvExpr) ir.Node {
 		return concreteRType(pos, src) // direct eface construction
 	}
 	if !src.IsInterface() {
-		return ITabAddr(src, dst) // direct iface construction
+		return ITabAddrAt(pos, src, dst) // direct iface construction
 	}
 	return TypePtrAt(pos, dst) // convI2I
 }