From: Robert Griesemer Date: Thu, 18 Oct 2018 19:37:25 +0000 (-0700) Subject: cmd/doc: minor code simplification X-Git-Tag: go1.12beta1~725 X-Git-Url: http://www.git.cypherpunks.su/?a=commitdiff_plain;h=2d6a7593b5cde33546be7bb69f420d32df060a47;p=gostls13.git cmd/doc: minor code simplification Follow-up on https://golang.org/cl/143037. Change-Id: Ia36760b499f7d46ce03e0fa81ec455a4a20208ac Reviewed-on: https://go-review.googlesource.com/c/143061 Run-TryBot: Robert Griesemer TryBot-Result: Gobot Gobot Reviewed-by: Rob Pike --- diff --git a/src/cmd/doc/pkg.go b/src/cmd/doc/pkg.go index 4b2479e75c..7c4e00767d 100644 --- a/src/cmd/doc/pkg.go +++ b/src/cmd/doc/pkg.go @@ -207,17 +207,15 @@ func (pkg *Package) newlines(n int) { // clears the stuff we don't want to print anyway. It's a bit of a magic trick. func (pkg *Package) emit(comment string, node ast.Node) { if node != nil { - var err error + var arg interface{} = node if showSrc { // Need an extra little dance to get internal comments to appear. - commentedNode := &printer.CommentedNode{ + arg = &printer.CommentedNode{ Node: node, Comments: pkg.file.Comments, } - err = format.Node(&pkg.buf, pkg.fs, commentedNode) - } else { - err = format.Node(&pkg.buf, pkg.fs, node) } + err := format.Node(&pkg.buf, pkg.fs, arg) if err != nil { log.Fatal(err) }