From: Alfonso Subiotto Marques <alfonsojssm@gmail.com>
Date: Mon, 3 Jun 2024 12:02:40 +0000 (+0000)
Subject: runtime: remove linkname from memhash{32,64} functions
X-Git-Tag: go1.24rc1~652
X-Git-Url: http://www.git.cypherpunks.su/?a=commitdiff_plain;h=2e9ed44d3943164636271f3242b21f0072b6caa7;p=gostls13.git

runtime: remove linkname from memhash{32,64} functions

Remove linkname directives that are no longer necessary given
parquet-go/parquet-go#142 removes the dependency on the `memhash{32,64}`
functions.

This change also removes references to segmentio/parquet-go since that
repository was archived in favor of parquet-go/parquet-go.

Updates #67401

Change-Id: Ibafb0c41b39cdb86dac5531f62787fb5cb8d3f01
GitHub-Last-Rev: e14c4e4dfe1023df83339da73eb5dd632d52851b
GitHub-Pull-Request: golang/go#67784
Reviewed-on: https://go-review.googlesource.com/c/go/+/589795
Auto-Submit: Ian Lance Taylor <iant@google.com>
Commit-Queue: Ian Lance Taylor <iant@google.com>
LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com>
Reviewed-by: Michael Pratt <mpratt@google.com>
Reviewed-by: Ian Lance Taylor <iant@google.com>
---

diff --git a/src/runtime/alg.go b/src/runtime/alg.go
index e183452fbe..07c115f74d 100644
--- a/src/runtime/alg.go
+++ b/src/runtime/alg.go
@@ -57,8 +57,6 @@ var useAeshash bool
 //   - github.com/outcaste-io/ristretto
 //   - github.com/puzpuzpuz/xsync/v2
 //   - github.com/puzpuzpuz/xsync/v3
-//   - github.com/segmentio/parquet-go
-//   - github.com/parquet-go/parquet-go
 //   - github.com/authzed/spicedb
 //   - github.com/pingcap/badger
 //
@@ -68,28 +66,8 @@ var useAeshash bool
 //go:linkname memhash
 func memhash(p unsafe.Pointer, h, s uintptr) uintptr
 
-// memhash32 should be an internal detail,
-// but widely used packages access it using linkname.
-// Notable members of the hall of shame include:
-//   - github.com/segmentio/parquet-go
-//   - github.com/parquet-go/parquet-go
-//
-// Do not remove or change the type signature.
-// See go.dev/issue/67401.
-//
-//go:linkname memhash32
 func memhash32(p unsafe.Pointer, h uintptr) uintptr
 
-// memhash64 should be an internal detail,
-// but widely used packages access it using linkname.
-// Notable members of the hall of shame include:
-//   - github.com/segmentio/parquet-go
-//   - github.com/parquet-go/parquet-go
-//
-// Do not remove or change the type signature.
-// See go.dev/issue/67401.
-//
-//go:linkname memhash64
 func memhash64(p unsafe.Pointer, h uintptr) uintptr
 
 // strhash should be an internal detail,