From: Hana Kim <hakim@google.com>
Date: Thu, 19 Oct 2017 21:47:07 +0000 (-0400)
Subject: cmd/trace: fix a javascript bug in handling import error
X-Git-Tag: go1.10beta1~652
X-Git-Url: http://www.git.cypherpunks.su/?a=commitdiff_plain;h=2f40dc79e5febf2c27303285ef853a5dd064f777;p=gostls13.git

cmd/trace: fix a javascript bug in handling import error

When traceviewer encounters a failure of json trace import
due to data error, onImportFail tried to access an error variable
which was not yet defined.

Change-Id: I431be03f179aafacaf1fd3c62a6337e8b5bd18fb
Reviewed-on: https://go-review.googlesource.com/71970
Reviewed-by: Austin Clements <austin@google.com>
---

diff --git a/src/cmd/trace/trace.go b/src/cmd/trace/trace.go
index 784e413335..7178287751 100644
--- a/src/cmd/trace/trace.go
+++ b/src/cmd/trace/trace.go
@@ -114,7 +114,7 @@ var templTrace = `
     viewer.viewTitle = "trace";
   }
 
-  function onImportFail() {
+  function onImportFail(err) {
     var overlay = new tr.ui.b.Overlay();
     overlay.textContent = tr.b.normalizeException(err).message;
     overlay.title = 'Import error';