From: Jamil Djadala Date: Wed, 20 Apr 2016 06:08:28 +0000 (+0300) Subject: container/heap: correct number of elements in BenchmarkDup X-Git-Tag: go1.7beta1~587 X-Git-Url: http://www.git.cypherpunks.su/?a=commitdiff_plain;h=30c278dbe907111b51737adb8ba0a9e1956f3ed5;p=gostls13.git container/heap: correct number of elements in BenchmarkDup In BenchmarkDup fuction, heap is created as h := make(myHeap, n) and then n elements are added, so first time there are 2*n elements in heap. Fixes #15380 Change-Id: I0508486a847006b3cd545fd695e8b09af339134f Reviewed-on: https://go-review.googlesource.com/22310 Reviewed-by: Brad Fitzpatrick Run-TryBot: Brad Fitzpatrick TryBot-Result: Gobot Gobot --- diff --git a/src/container/heap/heap_test.go b/src/container/heap/heap_test.go index b3d054c5f3..d41110422e 100644 --- a/src/container/heap/heap_test.go +++ b/src/container/heap/heap_test.go @@ -173,7 +173,7 @@ func TestRemove2(t *testing.T) { func BenchmarkDup(b *testing.B) { const n = 10000 - h := make(myHeap, n) + h := make(myHeap, 0, n) for i := 0; i < b.N; i++ { for j := 0; j < n; j++ { Push(&h, 0) // all elements are the same