From: Brad Fitzpatrick <bradfitz@golang.org>
Date: Tue, 28 Feb 2017 18:12:32 +0000 (+0000)
Subject: cmd/dist: make the vetall builder have test shards per os/arch
X-Git-Tag: go1.9beta1~1400
X-Git-Url: http://www.git.cypherpunks.su/?a=commitdiff_plain;h=31f9769c910e1470125fc80ff134e872980a3951;p=gostls13.git

cmd/dist: make the vetall builder have test shards per os/arch

This makes the vetall builder friendly to auto-sharding by the build
coordinator.

Change-Id: I0893f5051ec90e7a6adcb89904ba08cd2d590549
Reviewed-on: https://go-review.googlesource.com/37572
Reviewed-by: Josh Bleecher Snyder <josharian@gmail.com>
---

diff --git a/src/cmd/dist/test.go b/src/cmd/dist/test.go
index ef884625a6..227199ca22 100644
--- a/src/cmd/dist/test.go
+++ b/src/cmd/dist/test.go
@@ -338,16 +338,16 @@ var stdOutErrAreTerminals func() bool
 func (t *tester) registerTests() {
 	if strings.HasSuffix(os.Getenv("GO_BUILDER_NAME"), "-vetall") {
 		// Run vet over std and cmd and call it quits.
-		t.tests = append(t.tests, distTest{
-			name:    "vet/all",
-			heading: "go vet std cmd",
-			fn: func(dt *distTest) error {
-				// This runs vet/all for the current platform.
-				// TODO: on a fast builder or builders, run over all platforms.
-				t.addCmd(dt, "src/cmd/vet/all", "go", "run", "main.go", "-all")
-				return nil
-			},
-		})
+		for osarch := range cgoEnabled {
+			t.tests = append(t.tests, distTest{
+				name:    "vet/" + osarch,
+				heading: "go vet std cmd",
+				fn: func(dt *distTest) error {
+					t.addCmd(dt, "src/cmd/vet/all", "go", "run", "main.go", "-p="+osarch)
+					return nil
+				},
+			})
+		}
 		return
 	}