From: Josh Bleecher Snyder <josharian@gmail.com>
Date: Fri, 31 Mar 2017 17:28:54 +0000 (-0700)
Subject: cmd/compile: don't use lookupN for statictmps
X-Git-Tag: go1.9beta1~871
X-Git-Url: http://www.git.cypherpunks.su/?a=commitdiff_plain;h=3237af2da88c82d4938b392d2644d65637a11526;p=gostls13.git

cmd/compile: don't use lookupN for statictmps

The names never occur more than once,
so interning the results is counterproductive.

The impact is not very big, but neither is the fix.

name     old time/op     new time/op     delta
Unicode     90.2ms ± 3%     88.3ms ± 5%  -2.10%  (p=0.000 n=94+98)


Change-Id: I1e3a24433db4ae0c9a6e98166568941824ff0779
Reviewed-on: https://go-review.googlesource.com/39193
Run-TryBot: Josh Bleecher Snyder <josharian@gmail.com>
TryBot-Result: Gobot Gobot <gobot@golang.org>
Reviewed-by: Brad Fitzpatrick <bradfitz@golang.org>
---

diff --git a/src/cmd/compile/internal/gc/sinit.go b/src/cmd/compile/internal/gc/sinit.go
index fb6570cec1..0426b7e474 100644
--- a/src/cmd/compile/internal/gc/sinit.go
+++ b/src/cmd/compile/internal/gc/sinit.go
@@ -575,7 +575,7 @@ var statuniqgen int // name generator for static temps
 // Callers should call n.Name.SetReadonly(true) on the
 // returned node for readonly nodes.
 func staticname(t *Type) *Node {
-	n := newname(lookupN("statictmp_", statuniqgen))
+	n := newname(lookup(fmt.Sprintf("statictmp_%d", statuniqgen)))
 	statuniqgen++
 	addvar(n, t, PEXTERN)
 	return n