From: Than McIntosh Date: Thu, 13 Dec 2018 13:17:09 +0000 (-0500) Subject: go/internal/gccgoimporter: test fix for older gccgo versions X-Git-Tag: go1.12beta1~62 X-Git-Url: http://www.git.cypherpunks.su/?a=commitdiff_plain;h=3331608c1c1f357c26f46f028a2c5c6e23036d63;p=gostls13.git go/internal/gccgoimporter: test fix for older gccgo versions Avoid running the test for issue 29198 if the available copy of gccgo is too old (needs to support context package). Fixes a failure on the solaris builder. Updates #29198. Change-Id: I2b1b3438f4ac105432f30078fbef78e24f2077cd Reviewed-on: https://go-review.googlesource.com/c/153831 Run-TryBot: Than McIntosh TryBot-Result: Gobot Gobot Reviewed-by: Ian Lance Taylor --- diff --git a/src/go/internal/gccgoimporter/importer_test.go b/src/go/internal/gccgoimporter/importer_test.go index f678ddc3b5..7a21c5f2f4 100644 --- a/src/go/internal/gccgoimporter/importer_test.go +++ b/src/go/internal/gccgoimporter/importer_test.go @@ -159,7 +159,7 @@ func TestObjImporter(t *testing.T) { for _, test := range importerTests { // Support for type aliases was added in GCC 7. - if test.pkgpath == "aliases" || test.pkgpath == "issue27856" { + if test.pkgpath == "aliases" || test.pkgpath == "issue27856" || test.pkgpath == "issue29198" { if major < 7 { t.Logf("skipping %q: not supported before gccgo version 7", test.pkgpath) continue