From: Austin Clements <austin@google.com>
Date: Wed, 15 Nov 2017 22:26:33 +0000 (-0800)
Subject: runtime: remove TODO
X-Git-Tag: go1.10beta1~218
X-Git-Url: http://www.git.cypherpunks.su/?a=commitdiff_plain;h=366f46fe0084db6740b9db87dd36a52caf289025;p=gostls13.git

runtime: remove TODO

I experimented with changing the write barrier to take the value in SI
rather than AX to improve register allocation. It had no effect on
performance and only made the "hello world" text 0.07% smaller, so
let's just remove the comment.

Change-Id: I6a261d14139b7a02a8467b31e74951dfb927ffb4
Reviewed-on: https://go-review.googlesource.com/78033
Reviewed-by: Brad Fitzpatrick <bradfitz@golang.org>
Reviewed-by: Rick Hudson <rlh@golang.org>
---

diff --git a/src/runtime/asm_amd64.s b/src/runtime/asm_amd64.s
index ea48a8e3c0..7e13458b0b 100644
--- a/src/runtime/asm_amd64.s
+++ b/src/runtime/asm_amd64.s
@@ -2379,8 +2379,6 @@ TEXT runtime·addmoduledata(SB),NOSPLIT,$0-0
 // - AX is the value being written at DI
 // It clobbers FLAGS. It does not clobber any general-purpose registers,
 // but may clobber others (e.g., SSE registers).
-//
-// TODO: AX may be a bad choice because regalloc likes to use it.
 TEXT runtime·gcWriteBarrier(SB),NOSPLIT,$120
 	// Save the registers clobbered by the fast path.
 	//