From: Merrick Clay Date: Wed, 5 Jul 2023 21:06:39 +0000 (-0600) Subject: log/slog: fix faulty test X-Git-Tag: go1.21rc3~2^2~27 X-Git-Url: http://www.git.cypherpunks.su/?a=commitdiff_plain;h=36ea4f9680f8296f1c7d0cf7dbb1b3a9d572754a;p=gostls13.git log/slog: fix faulty test Adds an optional close quote in the expected log message regex for TestConnections to prevent failing when the source filepath is surrounded in quotes due to it containing one or more spaces. Fixes #61161 Change-Id: I0dd71fb4389bff963bbfdc668ef4e4dfe787eafc Reviewed-on: https://go-review.googlesource.com/c/go/+/508055 Reviewed-by: Jonathan Amsterdam Reviewed-by: Bryan Mills Run-TryBot: Bryan Mills TryBot-Result: Gopher Robot --- diff --git a/src/log/slog/logger_test.go b/src/log/slog/logger_test.go index d151c0490c..130f2e6ac8 100644 --- a/src/log/slog/logger_test.go +++ b/src/log/slog/logger_test.go @@ -106,7 +106,7 @@ func TestConnections(t *testing.T) { // log.Logger's output goes through the handler. SetDefault(New(NewTextHandler(&slogbuf, &HandlerOptions{AddSource: true}))) log.Print("msg2") - checkLogOutput(t, slogbuf.String(), "time="+timeRE+` level=INFO source=.*logger_test.go:\d{3} msg=msg2`) + checkLogOutput(t, slogbuf.String(), "time="+timeRE+` level=INFO source=.*logger_test.go:\d{3}"? msg=msg2`) // The default log.Logger always outputs at Info level. slogbuf.Reset()