From: qmuntal Date: Mon, 21 Nov 2022 12:56:19 +0000 (+0100) Subject: cmd/go,internal/platform: enable pie buildmode for windows/arm64 X-Git-Tag: go1.20rc1~132 X-Git-Url: http://www.git.cypherpunks.su/?a=commitdiff_plain;h=3732a178061f44fbde277def693368ce43e5e779;p=gostls13.git cmd/go,internal/platform: enable pie buildmode for windows/arm64 This CL adds windows/arm64 to the list of ports that supports PIE build mode. It is probably an oversight that this port is not marked as pie-capable because windows/arm64 only supports PIE build mode. Fixes #56872 Change-Id: I2bdd3ac207280f47ddcf8c2582f13025dafb9278 Reviewed-on: https://go-review.googlesource.com/c/go/+/452415 Run-TryBot: Cherry Mui Reviewed-by: Cherry Mui Reviewed-by: Bryan Mills TryBot-Result: Gopher Robot --- diff --git a/src/cmd/go/go_test.go b/src/cmd/go/go_test.go index 004edd76a4..d162dc8e2c 100644 --- a/src/cmd/go/go_test.go +++ b/src/cmd/go/go_test.go @@ -2136,7 +2136,7 @@ func TestBuildmodePIE(t *testing.T) { case "linux/386", "linux/amd64", "linux/arm", "linux/arm64", "linux/ppc64le", "linux/riscv64", "linux/s390x", "android/amd64", "android/arm", "android/arm64", "android/386", "freebsd/amd64", - "windows/386", "windows/amd64", "windows/arm": + "windows/386", "windows/amd64", "windows/arm", "windows/arm64": case "darwin/amd64": default: t.Skipf("skipping test because buildmode=pie is not supported on %s", platform) diff --git a/src/internal/platform/supported.go b/src/internal/platform/supported.go index fddc544123..86c9f07ade 100644 --- a/src/internal/platform/supported.go +++ b/src/internal/platform/supported.go @@ -129,7 +129,7 @@ func BuildModeSupported(compiler, buildmode, goos, goarch string) bool { "darwin/amd64", "darwin/arm64", "ios/amd64", "ios/arm64", "aix/ppc64", - "windows/386", "windows/amd64", "windows/arm": + "windows/386", "windows/amd64", "windows/arm", "windows/arm64": return true } return false