From: Kai Backman <kaib@golang.org>
Date: Wed, 30 Sep 2009 21:28:18 +0000 (-0700)
Subject: load binary op arguments into registers
X-Git-Tag: weekly.2009-11-06~439
X-Git-Url: http://www.git.cypherpunks.su/?a=commitdiff_plain;h=399d23d4f468bc3925629a82c0806858cd0523b8;p=gostls13.git

load binary op arguments into registers

go/test: passes 69% (237/339)

R=rsc
APPROVED=rsc
DELTA=12  (3 added, 9 deleted, 0 changed)
OCL=35178
CL=35180
---

diff --git a/src/cmd/5g/cgen.c b/src/cmd/5g/cgen.c
index 28b9631119..e6b632864c 100644
--- a/src/cmd/5g/cgen.c
+++ b/src/cmd/5g/cgen.c
@@ -364,18 +364,10 @@ sbop:	// symmetric binary
 	}
 
 abop:	// asymmetric binary
+	// TODO(kaib): use fewer registers here.
 	if(nl->ullman >= nr->ullman) {
 		regalloc(&n1, nl->type, res);
 		cgen(nl, &n1);
-
-		if(sudoaddable(a, nr, &addr, &w)) {
-			p1 = gins(a, N, &n1);
-			p1->from = addr;
-			gmove(&n1, res);
-			sudoclean();
-			regfree(&n1);
-			goto ret;
-		}
 		regalloc(&n2, nr->type, N);
 		cgen(nr, &n2);
 	} else {
diff --git a/test/arm-pass.txt b/test/arm-pass.txt
index 0baa67e742..de9e8db55a 100644
--- a/test/arm-pass.txt
+++ b/test/arm-pass.txt
@@ -213,6 +213,7 @@ ken/complit.go
 ken/for.go
 ken/label.go
 ken/mfunc.go
+ken/ptrvar.go
 ken/rob2.go
 ken/robfor.go
 ken/robif.go
@@ -221,6 +222,7 @@ ken/simpfun.go
 ken/simpprint.go
 ken/simpswitch.go
 ken/simpvar.go
+ken/strvar.go
 method1.go
 method2.go
 method3.go