From: Lynn Boger Date: Tue, 1 Nov 2016 15:43:34 +0000 (-0500) Subject: cmd/vendor/golang.org/x/arch/ppc64/ppc64asm: skip TestObjdumpPowerManual if not ppc64x X-Git-Tag: go1.8beta1~408 X-Git-Url: http://www.git.cypherpunks.su/?a=commitdiff_plain;h=3c2f607274b2284826ea887fa9d2ef62817df608;p=gostls13.git cmd/vendor/golang.org/x/arch/ppc64/ppc64asm: skip TestObjdumpPowerManual if not ppc64x Skip TestObjdumpPowerManual if the host system is not ppc64 or ppc64le. This test depends on using the host objdump and comparing output, which does not work as expected if the test is run on another host. Orignates from golang.org/x/arch/ppc64/ppc64asm commit 8e2d4898. Fixes #17698 Change-Id: I956b0fb78c5ec33641db752d46a755008403d269 Reviewed-on: https://go-review.googlesource.com/32531 Reviewed-by: Brad Fitzpatrick --- diff --git a/src/cmd/vendor/golang.org/x/arch/ppc64/ppc64asm/objdumpext_test.go b/src/cmd/vendor/golang.org/x/arch/ppc64/ppc64asm/objdumpext_test.go index 55cff31b45..7483543105 100644 --- a/src/cmd/vendor/golang.org/x/arch/ppc64/ppc64asm/objdumpext_test.go +++ b/src/cmd/vendor/golang.org/x/arch/ppc64/ppc64asm/objdumpext_test.go @@ -14,6 +14,7 @@ import ( "io" "log" "os" + "runtime" "strconv" "strings" "testing" @@ -25,6 +26,9 @@ func testObjdump(t *testing.T, generate func(func([]byte))) { if testing.Short() { t.Skip("skipping objdump test in short mode") } + if runtime.GOARCH != "ppc64le" && runtime.GOARCH != "ppc64" { + t.Skip("skipping; test requires host tool objdump for ppc64 or ppc64le") + } if _, err := os.Stat(objdumpPath); err != nil { t.Skip(err) }