From: Rob Pike <r@golang.org>
Date: Sat, 20 Jun 2015 23:10:39 +0000 (+1000)
Subject: cmd/asm: remove pointless check for negative uint
X-Git-Tag: go1.5beta1~161
X-Git-Url: http://www.git.cypherpunks.su/?a=commitdiff_plain;h=3cab4760d5ce8108c88984cb6c9849e598882b9b;p=gostls13.git

cmd/asm: remove pointless check for negative uint

Fixes #11278.

Change-Id: Ic46fda0f42cefedc3f6085c0e77e67616ce4955e
Reviewed-on: https://go-review.googlesource.com/11297
Reviewed-by: Brad Fitzpatrick <bradfitz@golang.org>
---

diff --git a/src/cmd/asm/internal/asm/parse.go b/src/cmd/asm/internal/asm/parse.go
index 72e91b8e55..7f956cb2a8 100644
--- a/src/cmd/asm/internal/asm/parse.go
+++ b/src/cmd/asm/internal/asm/parse.go
@@ -807,9 +807,7 @@ func (p *Parser) term() uint64 {
 		case lex.LSH:
 			p.next()
 			shift := p.factor()
-			if int64(shift) < 0 {
-				p.errorf("negative left shift %d", shift)
-			}
+			// shift is a uint, so can never be negative.
 			return value << shift
 		case lex.RSH:
 			p.next()