From: Austin Clements Date: Wed, 24 Feb 2021 02:22:20 +0000 (-0500) Subject: cmd/compile/internal-abi: update internal ABI spec for g register X-Git-Tag: go1.17beta1~1385 X-Git-Url: http://www.git.cypherpunks.su/?a=commitdiff_plain;h=3deb528199383b39425fc99f3741a6ade6ab5a6b;p=gostls13.git cmd/compile/internal-abi: update internal ABI spec for g register We've already implemented dedicating R14 as the G register on amd64, so remove the TODO saying we might want to hold off on this. For #40724. Change-Id: I45b24ced03cac862127b53f5e9a4b4bcf6b1f86c Reviewed-on: https://go-review.googlesource.com/c/go/+/295790 Trust: Austin Clements Reviewed-by: Cherry Zhang Reviewed-by: Than McIntosh --- diff --git a/src/cmd/compile/internal-abi.md b/src/cmd/compile/internal-abi.md index 3a3509d8c2..0e5d8ce260 100644 --- a/src/cmd/compile/internal-abi.md +++ b/src/cmd/compile/internal-abi.md @@ -402,9 +402,6 @@ Special-purpose registers are as follows: | R15 | GOT reference temporary | Fixed if dynlink | | X15 | Zero value | Fixed | -TODO: We may start with the existing TLS-based g and move to R14 -later. - *Rationale*: These register meanings are compatible with Go’s stack-based calling convention except for R14 and X15, which will have to be restored on transitions from ABI0 code to ABIInternal code.