From: qmuntal <quimmuntal@gmail.com>
Date: Thu, 3 Nov 2022 14:30:42 +0000 (+0100)
Subject: cmd/go/internal/script: Cmp() should not perform environment substitutions
X-Git-Tag: go1.20rc1~446
X-Git-Url: http://www.git.cypherpunks.su/?a=commitdiff_plain;h=3e3a8fe5bed87845e7c93da50378403564ad9e69;p=gostls13.git

cmd/go/internal/script: Cmp() should not perform environment substitutions

This is an oversight from https://go-review.googlesource.com/c/go/+/419875,
where script commands were refactored and factored out to a new package.

For #27494.

Change-Id: Ie606cab39f60859ee1da5165dcc94c8470c94325
Reviewed-on: https://go-review.googlesource.com/c/go/+/447575
Run-TryBot: Quim Muntal <quimmuntal@gmail.com>
Reviewed-by: Bryan Mills <bcmills@google.com>
TryBot-Result: Gopher Robot <gobot@golang.org>
Auto-Submit: Bryan Mills <bcmills@google.com>
Reviewed-by: Than McIntosh <thanm@google.com>
---

diff --git a/src/cmd/go/internal/script/cmds.go b/src/cmd/go/internal/script/cmds.go
index 393f565733..90e7fb9570 100644
--- a/src/cmd/go/internal/script/cmds.go
+++ b/src/cmd/go/internal/script/cmds.go
@@ -188,7 +188,7 @@ func Cmp() Cmd {
 			},
 		},
 		func(s *State, args ...string) (WaitFunc, error) {
-			return nil, doCompare(s, true, args...)
+			return nil, doCompare(s, false, args...)
 		})
 }