From: Cuong Manh Le Date: Sun, 25 Apr 2021 08:46:30 +0000 (+0700) Subject: cmd/compile: fix wrong package path for unsafe.Pointer X-Git-Tag: go1.17beta1~442 X-Git-Url: http://www.git.cypherpunks.su/?a=commitdiff_plain;h=40254ec0db;p=gostls13.git cmd/compile: fix wrong package path for unsafe.Pointer It's not a predeclared type, but a type defined in "unsafe" package. Fixes #44830 Change-Id: If39815b1070059b608be8231dfac9b7f3307cb15 Reviewed-on: https://go-review.googlesource.com/c/go/+/313349 Trust: Cuong Manh Le Run-TryBot: Cuong Manh Le TryBot-Result: Go Bot Reviewed-by: Matthew Dempsky --- diff --git a/src/cmd/compile/internal/reflectdata/reflect.go b/src/cmd/compile/internal/reflectdata/reflect.go index d23ca6b839..26b08ee08a 100644 --- a/src/cmd/compile/internal/reflectdata/reflect.go +++ b/src/cmd/compile/internal/reflectdata/reflect.go @@ -595,7 +595,7 @@ func typePkg(t *types.Type) *types.Pkg { } } } - if tsym != nil && t != types.Types[t.Kind()] && t != types.ErrorType { + if tsym != nil && tsym.Pkg != types.BuiltinPkg { return tsym.Pkg } return nil diff --git a/test/fixedbugs/issue44830.go b/test/fixedbugs/issue44830.go new file mode 100644 index 0000000000..7df5aeb857 --- /dev/null +++ b/test/fixedbugs/issue44830.go @@ -0,0 +1,19 @@ +// run + +// Copyright 2021 The Go Authors. All rights reserved. +// Use of this source code is governed by a BSD-style +// license that can be found in the LICENSE file. + +package main + +import ( + "reflect" + "unsafe" +) + +func main() { + t := reflect.TypeOf(unsafe.Pointer(nil)) + if pkgPath := t.PkgPath(); pkgPath != "unsafe" { + panic("unexpected t.PkgPath(): " + pkgPath) + } +}