From: Robert Griesemer Date: Tue, 5 Jun 2018 23:29:06 +0000 (-0700) Subject: cmd/compile: avoid nil pointer deref in debugging output X-Git-Tag: go1.11beta1~210 X-Git-Url: http://www.git.cypherpunks.su/?a=commitdiff_plain;h=409a943f69b27a329c523230ec83d0fef495c20a;p=gostls13.git cmd/compile: avoid nil pointer deref in debugging output Found while tracking down another issue. Change-Id: If06eee72ce3e3f45dc00b3b68670e1e4d99c87a7 Reviewed-on: https://go-review.googlesource.com/116455 Run-TryBot: Robert Griesemer Reviewed-by: Brad Fitzpatrick TryBot-Result: Gobot Gobot --- diff --git a/src/cmd/compile/internal/gc/fmt.go b/src/cmd/compile/internal/gc/fmt.go index 598930bf15..75194ca6f0 100644 --- a/src/cmd/compile/internal/gc/fmt.go +++ b/src/cmd/compile/internal/gc/fmt.go @@ -1599,7 +1599,7 @@ func (n *Node) nodedump(s fmt.State, flag FmtFlag, mode fmtMode) { case OTYPE: mode.Fprintf(s, "%v %v%j type=%v", n.Op, n.Sym, n, n.Type) - if recur && n.Type == nil && n.Name.Param.Ntype != nil { + if recur && n.Type == nil && n.Name != nil && n.Name.Param != nil && n.Name.Param.Ntype != nil { indent(s) mode.Fprintf(s, "%v-ntype%v", n.Op, n.Name.Param.Ntype) }