From: Hana Kim <hakim@google.com>
Date: Thu, 31 May 2018 17:16:24 +0000 (-0400)
Subject: cmd/pprof: fix help message formatting error
X-Git-Tag: go1.11beta1~245
X-Git-Url: http://www.git.cypherpunks.su/?a=commitdiff_plain;h=424c2157392d46220213610a290a275c36ddcd97;p=gostls13.git

cmd/pprof: fix help message formatting error

Pprof usage message includes "%" symbols. Misuse of Fprintf caused
the message to be interpreted as a format string and corrupted the usage
message.

Change-Id: I4732b491e2368cff9fdbfe070c125228d6f506fd
Reviewed-on: https://go-review.googlesource.com/115595
Reviewed-by: Brad Fitzpatrick <bradfitz@golang.org>
---

diff --git a/src/cmd/pprof/readlineui.go b/src/cmd/pprof/readlineui.go
index 67fb7aa49c..6e91816f9b 100644
--- a/src/cmd/pprof/readlineui.go
+++ b/src/cmd/pprof/readlineui.go
@@ -86,7 +86,7 @@ func (r *readlineUI) print(withColor bool, args ...interface{}) {
 	if withColor {
 		text = colorize(text)
 	}
-	fmt.Fprintf(r.term, text)
+	fmt.Fprint(r.term, text)
 }
 
 // colorize prints the msg in red using ANSI color escapes.