From: Jay Conrod <jayconrod@google.com>
Date: Tue, 14 Sep 2021 22:09:06 +0000 (-0700)
Subject: [dev.fuzz] testing: fix internal error exit condition for fuzz workers
X-Git-Tag: go1.18beta1~1282^2~6
X-Git-Url: http://www.git.cypherpunks.su/?a=commitdiff_plain;h=4304cf62e9ba6a85e37d5fec33cfa580ce7ac6d1;p=gostls13.git

[dev.fuzz] testing: fix internal error exit condition for fuzz workers

A fuzz worker process should exit with fuzzWorkerExitCode (70) if it
encounters an internal error.

This should generally only happen due to an I/O error on the worker
side. I can't think of a way to write a realistic test case for
this. test_fuzz_io_error.txt triggers an I/O error on the coordinator
side, which is similar.

Change-Id: I40d2e9aaf422e5ed925debcf7a152c252c3a6984
Reviewed-on: https://go-review.googlesource.com/c/go/+/349993
Trust: Jay Conrod <jayconrod@google.com>
Trust: Katie Hockman <katie@golang.org>
Reviewed-by: Katie Hockman <katie@golang.org>
---

diff --git a/src/testing/testing.go b/src/testing/testing.go
index f4d2b26650..18a0657561 100644
--- a/src/testing/testing.go
+++ b/src/testing/testing.go
@@ -1635,7 +1635,7 @@ func (m *M) Run() (code int) {
 	}
 
 	fuzzingOk := runFuzzing(m.deps, m.fuzzTargets)
-	if !*isFuzzWorker && !fuzzingOk {
+	if !fuzzingOk {
 		fmt.Println("FAIL")
 		if *isFuzzWorker {
 			m.exitCode = fuzzWorkerExitCode