From: Sean Liao <sean@liao.dev>
Date: Fri, 19 Jul 2024 23:09:13 +0000 (+0100)
Subject: testing/slogtest: reuse results obtained from previous call
X-Git-Tag: go1.24rc1~409
X-Git-Url: http://www.git.cypherpunks.su/?a=commitdiff_plain;h=4310502385ad5baca82071e81fc0490525f10eb1;p=gostls13.git

testing/slogtest: reuse results obtained from previous call

Fixes #67605

Change-Id: Ib48ddfabb93887c88bfca347ba2e5f3c4b4e90b3
Reviewed-on: https://go-review.googlesource.com/c/go/+/599836
LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com>
Auto-Submit: Michael Pratt <mpratt@google.com>
Reviewed-by: Damien Neil <dneil@google.com>
Reviewed-by: Alan Donovan <adonovan@google.com>
---

diff --git a/src/testing/slogtest/slogtest.go b/src/testing/slogtest/slogtest.go
index 5c3aced65b..f9e2d90041 100644
--- a/src/testing/slogtest/slogtest.go
+++ b/src/testing/slogtest/slogtest.go
@@ -265,7 +265,7 @@ func TestHandler(h slog.Handler, results func() []map[string]any) error {
 	if g, w := len(res), len(cases); g != w {
 		return fmt.Errorf("got %d results, want %d", g, w)
 	}
-	for i, got := range results() {
+	for i, got := range res {
 		c := cases[i]
 		for _, check := range c.checks {
 			if problem := check(got); problem != "" {