From: Jorropo <jorropo.pgm@gmail.com>
Date: Thu, 20 Feb 2025 10:50:53 +0000 (+0100)
Subject: [release-branch.go1.24] cmd/compile: don't report newLimit discovered when unsat... 
X-Git-Tag: go1.24.1~11
X-Git-Url: http://www.git.cypherpunks.su/?a=commitdiff_plain;h=456eaf5c29f7a9e8a222ad37a29c960884b5d9ed;p=gostls13.git

[release-branch.go1.24] cmd/compile: don't report newLimit discovered when unsat happens multiple times

Fixes #71855

Change-Id: I696fcb8fc8c0c2e5e5ae6ab50596f6bdb9b7d498
Reviewed-on: https://go-review.googlesource.com/c/go/+/650975
LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com>
Reviewed-by: Keith Randall <khr@google.com>
Reviewed-by: Michael Knyszek <mknyszek@google.com>
Reviewed-by: Keith Randall <khr@golang.org>
(cherry picked from commit 00635de759b38610dd86f60074856367d6a1ceaa)
Reviewed-on: https://go-review.googlesource.com/c/go/+/652179
Reviewed-by: Jorropo <jorropo.pgm@gmail.com>
Reviewed-by: Michael Pratt <mpratt@google.com>
---

diff --git a/src/cmd/compile/internal/ssa/prove.go b/src/cmd/compile/internal/ssa/prove.go
index c3948dc9b1..6a8c2d5890 100644
--- a/src/cmd/compile/internal/ssa/prove.go
+++ b/src/cmd/compile/internal/ssa/prove.go
@@ -552,8 +552,9 @@ func (ft *factsTable) newLimit(v *Value, newLim limit) bool {
 	}
 
 	if lim.unsat() {
+		r := !ft.unsat
 		ft.unsat = true
-		return true
+		return r
 	}
 
 	// Check for recursion. This normally happens because in unsatisfiable
diff --git a/test/fixedbugs/issue71852.go b/test/fixedbugs/issue71852.go
new file mode 100644
index 0000000000..a0bc0925e3
--- /dev/null
+++ b/test/fixedbugs/issue71852.go
@@ -0,0 +1,23 @@
+// compile
+
+// Copyright 2025 The Go Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style
+// license that can be found in the LICENSE file.
+
+package main
+
+import (
+	"math"
+)
+
+func main() {
+	test(2)
+}
+
+func test(i int) {
+	if i <= 0 {
+		return
+	}
+
+	_ = math.Pow10(i + 2)
+}