From: Michael Pratt <mpratt@google.com>
Date: Wed, 2 Oct 2024 21:20:12 +0000 (-0400)
Subject: syscall: use SYS_EXIT_GROUP in CLONE_PIDFD feature check child
X-Git-Tag: go1.24rc1~762
X-Git-Url: http://www.git.cypherpunks.su/?a=commitdiff_plain;h=47a99359206f0dd41228deda0aa31f1e769cc156;p=gostls13.git

syscall: use SYS_EXIT_GROUP in CLONE_PIDFD feature check child

Inside Google we have seen issues with QEMU user mode failing to wake a
parent waitid when this child exits with SYS_EXIT. This bug appears to
not affect SYS_EXIT_GROUP.

It is currently unclear if this is a general QEMU or specific to
Google's configuration, but SYS_EXIT and SYS_EXIT_GROUP are semantically
equivalent here, so we can use the latter here in case this is a general
QEMU bug.

For #68976.

Change-Id: I34e51088c9a6b7493a060e2a719a3cc4a3d54aa0
Reviewed-on: https://go-review.googlesource.com/c/go/+/617417
Reviewed-by: Ian Lance Taylor <iant@google.com>
LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com>
---

diff --git a/src/syscall/exec_linux.go b/src/syscall/exec_linux.go
index a258b1591e..0009080d68 100644
--- a/src/syscall/exec_linux.go
+++ b/src/syscall/exec_linux.go
@@ -836,6 +836,6 @@ func doCheckClonePidfd(pidfd *int32) (pid uintptr, errno Errno) {
 	}
 
 	for {
-		RawSyscall(SYS_EXIT, 0, 0, 0)
+		RawSyscall(SYS_EXIT_GROUP, 0, 0, 0)
 	}
 }