From: Felix Geisendörfer <felix.geisendoerfer@datadoghq.com>
Date: Wed, 26 Apr 2023 08:02:22 +0000 (+0200)
Subject: runtime: remove systemstack logic from adjustframe
X-Git-Tag: go1.21rc1~713
X-Git-Url: http://www.git.cypherpunks.su/?a=commitdiff_plain;h=47e6fd05f7d605774864984f70e5a93355109a61;p=gostls13.git

runtime: remove systemstack logic from adjustframe

Remove logic for skipping some adjustframe logic for systemstack (aka
FuncID_systemstack_switch). This was introduced in 2014 by
9198ed4bd6ec7b7dd37aa2797e96f15ddbb1e6cd but doesn't seem to be needed
anymore.

Updates #59692

Change-Id: I2368d64f9bb28ced4e7f15c9b15dac7a29194389
Reviewed-on: https://go-review.googlesource.com/c/go/+/489116
Reviewed-by: Michael Knyszek <mknyszek@google.com>
TryBot-Result: Gopher Robot <gobot@golang.org>
Run-TryBot: Felix Geisendörfer <felix.geisendoerfer@datadoghq.com>
Reviewed-by: Cherry Mui <cherryyz@google.com>
---

diff --git a/src/runtime/stack.go b/src/runtime/stack.go
index 01d6b9c22f..45d66da91f 100644
--- a/src/runtime/stack.go
+++ b/src/runtime/stack.go
@@ -676,13 +676,6 @@ func adjustframe(frame *stkframe, adjinfo *adjustinfo) {
 		adjustpointer(adjinfo, unsafe.Pointer(frame.varp))
 	}
 
-	if f.funcID == abi.FuncID_systemstack_switch {
-		// A special routine at the bottom of stack of a goroutine that does a systemstack call.
-		// We will allow it to be copied even though we don't
-		// have full GC info for it (because it is written in asm).
-		return
-	}
-
 	locals, args, objs := frame.getStackMap(&adjinfo.cache, true)
 
 	// Adjust local variables if stack frame has been allocated.