From: Cuong Manh Le <cuong.manhle.vn@gmail.com>
Date: Sat, 27 Aug 2022 15:08:09 +0000 (+0700)
Subject: reflect: clarify Value.Equal behavior for non-comparable values
X-Git-Tag: go1.20rc1~1350
X-Git-Url: http://www.git.cypherpunks.su/?a=commitdiff_plain;h=47f8db368cbb1971f386717ae7c76a1891a6130c;p=gostls13.git

reflect: clarify Value.Equal behavior for non-comparable values

The current implementation always returns false for non-comparable
values, update the doc to reflect that.

Change-Id: I87f2da408874b0a209c8f51949e3310da15c5904
Reviewed-on: https://go-review.googlesource.com/c/go/+/426195
Reviewed-by: Ian Lance Taylor <iant@google.com>
Reviewed-by: xie cui <523516579@qq.com>
TryBot-Result: Gopher Robot <gobot@golang.org>
Reviewed-by: hopehook <hopehook@golangcn.org>
Reviewed-by: Heschi Kreinick <heschi@google.com>
Run-TryBot: Cuong Manh Le <cuong.manhle.vn@gmail.com>
Reviewed-by: Cherry Mui <cherryyz@google.com>
---

diff --git a/src/reflect/value.go b/src/reflect/value.go
index 061545bd4f..3611a5a66c 100644
--- a/src/reflect/value.go
+++ b/src/reflect/value.go
@@ -3309,6 +3309,7 @@ func (v Value) Comparable() bool {
 }
 
 // Equal reports true if v is equal to u.
+// For valid values, if either v or u is non-comparable, Equal returns false.
 func (v Value) Equal(u Value) bool {
 	if !v.IsValid() || !u.IsValid() {
 		return v.IsValid() == u.IsValid()