From: Rob Pike <r@golang.org>
Date: Fri, 27 Jul 2012 23:13:29 +0000 (-0700)
Subject: flag: fix bug in handling of booleans on error
X-Git-Tag: go1.1rc2~2765
X-Git-Url: http://www.git.cypherpunks.su/?a=commitdiff_plain;h=48ca3f288c112130d6ab4afabdb375f970652874;p=gostls13.git

flag: fix bug in handling of booleans on error
Fixes #3869.

R=golang-dev, dsymonds
CC=golang-dev
https://golang.org/cl/6448072
---

diff --git a/src/pkg/flag/flag.go b/src/pkg/flag/flag.go
index 3116dafb5a..bbabd88c8c 100644
--- a/src/pkg/flag/flag.go
+++ b/src/pkg/flag/flag.go
@@ -707,7 +707,7 @@ func (f *FlagSet) parseOne() (bool, error) {
 	if fv, ok := flag.Value.(*boolValue); ok { // special case: doesn't need an arg
 		if has_value {
 			if err := fv.Set(value); err != nil {
-				f.failf("invalid boolean value %q for  -%s: %v", value, name, err)
+				return false, f.failf("invalid boolean value %q for  -%s: %v", value, name, err)
 			}
 		} else {
 			fv.Set("true")