From: Shenghou Ma Date: Sun, 6 Oct 2019 12:03:44 +0000 (-0400) Subject: [release-branch.go1.13] os: re-enable TestPipeThreads on darwin X-Git-Tag: go1.13.3~10 X-Git-Url: http://www.git.cypherpunks.su/?a=commitdiff_plain;h=49073c579e02ad97a1c3e0b645c4cac1a3622fb6;p=gostls13.git [release-branch.go1.13] os: re-enable TestPipeThreads on darwin CL 197938 actually fixes those regression on Darwin as syscalls are no longer labeled as always blocking and consume a thread. Fixes #34712 Change-Id: I82c98516c23cd36f762bc5433d7b71ea8939a0ac Reviewed-on: https://go-review.googlesource.com/c/go/+/199477 Run-TryBot: Minux Ma TryBot-Result: Gobot Gobot Reviewed-by: Tobias Klauser (cherry picked from commit cfe232042981972dc0c7e8d741a04556ecaae3c3) Reviewed-on: https://go-review.googlesource.com/c/go/+/200105 Run-TryBot: Alexander Rakoczy Reviewed-by: Bryan C. Mills Reviewed-by: Cherry Zhang --- diff --git a/src/os/os_test.go b/src/os/os_test.go index 974374ec66..b94ab0d232 100644 --- a/src/os/os_test.go +++ b/src/os/os_test.go @@ -2254,8 +2254,6 @@ func TestPipeThreads(t *testing.T) { t.Skip("skipping on Plan 9; does not support runtime poller") case "js": t.Skip("skipping on js; no support for os.Pipe") - case "darwin": - t.Skip("skipping on Darwin; issue 33953") } threads := 100