From: David du Colombier <0intro@gmail.com> Date: Mon, 26 Mar 2018 08:41:11 +0000 (+0200) Subject: os: fix TestDevNullFile on Plan 9 X-Git-Tag: go1.11beta1~1093 X-Git-Url: http://www.git.cypherpunks.su/?a=commitdiff_plain;h=49325dc1d23b74eed40ea414c015f080acf21a32;p=gostls13.git os: fix TestDevNullFile on Plan 9 CL 102457 added TestDevNullFile. However, this test is failing on Plan 9, because it checks that /dev/null is a character device while there are no special files on Plan 9. We fix this issue by changing Stat to consider all files served by the console device (#c) as character devices. Fixes #24534. Change-Id: I1c60cdf25770358b908790b3fb71910fa914dec0 Reviewed-on: https://go-review.googlesource.com/102424 Run-TryBot: David du Colombier <0intro@gmail.com> Reviewed-by: Alex Brainman Reviewed-by: Rob Pike TryBot-Result: Gobot Gobot --- diff --git a/src/os/stat_plan9.go b/src/os/stat_plan9.go index 15999c001c..b43339afa4 100644 --- a/src/os/stat_plan9.go +++ b/src/os/stat_plan9.go @@ -35,6 +35,10 @@ func fileInfoFromStat(d *syscall.Dir) FileInfo { if d.Type != 'M' { fs.mode |= ModeDevice } + // Consider all files served by #c as character device files. + if d.Type == 'c' { + fs.mode |= ModeCharDevice + } return fs }