From: Russ Cox <rsc@golang.org>
Date: Thu, 28 Jan 2010 20:48:21 +0000 (-0800)
Subject: codereview: make sure each mail has a reviewer
X-Git-Tag: weekly.2010-02-04~75
X-Git-Url: http://www.git.cypherpunks.su/?a=commitdiff_plain;h=4967f857d56f6f98b73250692a7901545716b5a6;p=gostls13.git

codereview: make sure each mail has a reviewer

R=r
CC=golang-dev
https://golang.org/cl/196050
---

diff --git a/lib/codereview/codereview.py b/lib/codereview/codereview.py
index 9f7470be52..a33ea38c06 100644
--- a/lib/codereview/codereview.py
+++ b/lib/codereview/codereview.py
@@ -960,8 +960,16 @@ def mail(ui, repo, *pats, **opts):
 	if err != "":
 		return err
 	cl.Upload(ui, repo, gofmt_just_warn=True)
-	if not cl.reviewer and not cl.cc:
-		return "no reviewers listed in CL"
+	if not cl.reviewer:
+		# If no reviewer is listed, assign the review to defaultcc.
+		# This makes sure that it appears in the 
+		# codereview.appspot.com/user/defaultcc
+		# page, so that it doesn't get dropped on the floor.
+		if not defaultcc:
+			return "no reviewers listed in CL"
+		cl.cc = Sub(cl.cc, defaultcc)
+		cl.reviewer = defaultcc
+		cl.Flush(ui, repo)		
 	cl.Mail(ui, repo)
 
 def nocommit(ui, repo, *pats, **opts):