From: Bryan C. Mills <bcmills@google.com>
Date: Wed, 18 Nov 2020 18:44:39 +0000 (-0500)
Subject: cmd/go/internal/work: avoid modload.Selected in 'go install pkg@version'
X-Git-Tag: go1.16beta1~196
X-Git-Url: http://www.git.cypherpunks.su/?a=commitdiff_plain;h=498d8d537153a210e45d356d779aee74de5acda1;p=gostls13.git

cmd/go/internal/work: avoid modload.Selected in 'go install pkg@version'

At this point in installOutsideModule the build list is empty, so
Selected trivially returns "none" for all modules.

(This change could have been made in CL 266657, but it was a bit
simpler to update the QueryPattern call sites mechanically to ensure
that there would be no unintentional semantic drift.)

For #36460

Change-Id: I44fb73794985bfeebb1dde0c092313f319c2945a
Reviewed-on: https://go-review.googlesource.com/c/go/+/271419
Trust: Bryan C. Mills <bcmills@google.com>
Run-TryBot: Bryan C. Mills <bcmills@google.com>
TryBot-Result: Go Bot <gobot@golang.org>
Reviewed-by: Jay Conrod <jayconrod@google.com>
---

diff --git a/src/cmd/go/internal/work/build.go b/src/cmd/go/internal/work/build.go
index 0f91a86311..e0aa691659 100644
--- a/src/cmd/go/internal/work/build.go
+++ b/src/cmd/go/internal/work/build.go
@@ -765,7 +765,8 @@ func installOutsideModule(ctx context.Context, args []string) {
 		// Don't check for retractions if a specific revision is requested.
 		allowed = nil
 	}
-	qrs, err := modload.QueryPackages(ctx, patterns[0], version, modload.Selected, allowed)
+	noneSelected := func(path string) (version string) { return "none" }
+	qrs, err := modload.QueryPackages(ctx, patterns[0], version, noneSelected, allowed)
 	if err != nil {
 		base.Fatalf("go install %s: %v", args[0], err)
 	}