From: Russ Cox <rsc@golang.org>
Date: Thu, 26 Aug 2010 21:06:36 +0000 (-0400)
Subject: codereview: fix hang on standard hg commands
X-Git-Tag: weekly.2010-09-06~73
X-Git-Url: http://www.git.cypherpunks.su/?a=commitdiff_plain;h=4ae2b43ef23ef0e187a923fdf1ca61c33e7faef2;p=gostls13.git

codereview: fix hang on standard hg commands

R=gri
CC=golang-dev
https://golang.org/cl/1950045
---

diff --git a/lib/codereview/codereview.py b/lib/codereview/codereview.py
index 3d87f298f4..4b03b085f2 100644
--- a/lib/codereview/codereview.py
+++ b/lib/codereview/codereview.py
@@ -457,7 +457,9 @@ class StatusThread(threading.Thread):
 			print >>sys.stderr, time.asctime(), s
 
 def start_status_thread():
-	StatusThread().start()
+	t = StatusThread()
+	t.setDaemon(True)  # allowed to exit if t is still running
+	t.start()
 
 class LoadCLThread(threading.Thread):
 	def __init__(self, ui, repo, dir, f, web):