From: Clide Stefani <cstefani.sites@gmail.com>
Date: Fri, 7 Jun 2024 20:37:13 +0000 (-0400)
Subject: crypto/tls: improve error log produced during TestBogoSuite
X-Git-Tag: go1.23rc1~39
X-Git-Url: http://www.git.cypherpunks.su/?a=commitdiff_plain;h=4b8f80707f315a8f7611da4f977892bbb8d49582;p=gostls13.git

crypto/tls: improve error log produced during TestBogoSuite

The existing implementation logs some errors to the results file created in TestBogoSuite.
This change would additionally log json errors to the results file.

Change-Id: Ib1a6f612ed83f6c5046531ee259c4e85dd71402a
Reviewed-on: https://go-review.googlesource.com/c/go/+/591379
Reviewed-by: Filippo Valsorda <filippo@golang.org>
Auto-Submit: Filippo Valsorda <filippo@golang.org>
Reviewed-by: Roland Shoemaker <roland@golang.org>
Reviewed-by: Michael Pratt <mpratt@google.com>
LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com>
---

diff --git a/src/crypto/tls/bogo_shim_test.go b/src/crypto/tls/bogo_shim_test.go
index 09b20a1c70..5dc3b7c13e 100644
--- a/src/crypto/tls/bogo_shim_test.go
+++ b/src/crypto/tls/bogo_shim_test.go
@@ -368,7 +368,7 @@ func TestBogoSuite(t *testing.T) {
 		if err != nil {
 			t.Fatalf("bogo failed: %s\n%s", err, out)
 		}
-		t.Fatalf("failed to read results JSON file: %s", err)
+		t.Fatalf("failed to read results JSON file: %s", jsonErr)
 	}
 
 	var results bogoResults