From: Ian Lance Taylor <iant@golang.org>
Date: Fri, 19 Apr 2019 16:50:01 +0000 (-0700)
Subject: cmd/link: require cgo support for TestSectionsWithSameName
X-Git-Tag: go1.13beta1~629
X-Git-Url: http://www.git.cypherpunks.su/?a=commitdiff_plain;h=4c236b9b097882f3aef8116e1ac9f65463bf6f01;p=gostls13.git

cmd/link: require cgo support for TestSectionsWithSameName

The test doesn't really require cgo, but it does require that we know
the right flags to use to run the C compiler, and that is not
necessarily correct if we don't support cgo.

Fixes #31565

Change-Id: I04dc8db26697caa470e91ad712376aa621cf765d
Reviewed-on: https://go-review.googlesource.com/c/go/+/172981
Run-TryBot: Ian Lance Taylor <iant@golang.org>
Reviewed-by: Brad Fitzpatrick <bradfitz@golang.org>
TryBot-Result: Gobot Gobot <gobot@golang.org>
---

diff --git a/src/cmd/link/elf_test.go b/src/cmd/link/elf_test.go
index 9eb8d1a14b..3df9869284 100644
--- a/src/cmd/link/elf_test.go
+++ b/src/cmd/link/elf_test.go
@@ -34,6 +34,7 @@ func main() {}
 // with the same name.
 func TestSectionsWithSameName(t *testing.T) {
 	testenv.MustHaveGoBuild(t)
+	testenv.MustHaveCGO(t)
 	t.Parallel()
 
 	objcopy, err := exec.LookPath("objcopy")
@@ -77,7 +78,7 @@ func TestSectionsWithSameName(t *testing.T) {
 	cflags := strings.Fields(string(cflagsb))
 
 	asmObj := filepath.Join(dir, "x.o")
-	t.Logf("%s %v -o %s %s", cc, cflags, asmObj, asmFile)
+	t.Logf("%s %v -c -o %s %s", cc, cflags, asmObj, asmFile)
 	if out, err := exec.Command(cc, append(cflags, "-c", "-o", asmObj, asmFile)...).CombinedOutput(); err != nil {
 		t.Logf("%s", out)
 		t.Fatal(err)