From: Russ Cox Date: Wed, 3 Dec 2014 19:14:50 +0000 (-0500) Subject: [release-branch.go1.4] cmd/pprof: fix symbol resolution for remote profiles X-Git-Tag: go1.4~18 X-Git-Url: http://www.git.cypherpunks.su/?a=commitdiff_plain;h=4d1f720b70c8b73b35a34c2c2ea0764ab5454c45;p=gostls13.git [release-branch.go1.4] cmd/pprof: fix symbol resolution for remote profiles ««« CL 183080043 / b663cc7e6c15 cmd/pprof: fix symbol resolution for remote profiles Fixes #9199. LGTM=iant R=golang-codereviews, iant CC=austin, golang-codereviews, minux https://golang.org/cl/183080043 »»» TBR=iant CC=golang-codereviews https://golang.org/cl/176680043 --- diff --git a/src/cmd/pprof/internal/symbolizer/symbolizer.go b/src/cmd/pprof/internal/symbolizer/symbolizer.go index cabddaa76e..86de5640d2 100644 --- a/src/cmd/pprof/internal/symbolizer/symbolizer.go +++ b/src/cmd/pprof/internal/symbolizer/symbolizer.go @@ -32,6 +32,10 @@ func Symbolize(mode string, prof *profile.Profile, obj plugin.ObjTool, ui plugin } } + if len(prof.Mapping) == 0 { + return fmt.Errorf("no known mappings") + } + mt, err := newMapping(prof, obj, ui, force) if err != nil { return err