From: Shenghou Ma <minux@golang.org>
Date: Wed, 16 Nov 2016 06:05:34 +0000 (-0500)
Subject: cmd/link/internal/ld: always show output from external linker
X-Git-Tag: go1.9beta1~347
X-Git-Url: http://www.git.cypherpunks.su/?a=commitdiff_plain;h=4d7a5edb7e476a321365151a3253395c25185341;p=gostls13.git

cmd/link/internal/ld: always show output from external linker

Fixes #17935.

Change-Id: I49b0f6cee29ea76ed62b8faa5d6d1f51be41bf84
Reviewed-on: https://go-review.googlesource.com/33301
Run-TryBot: Brad Fitzpatrick <bradfitz@golang.org>
TryBot-Result: Gobot Gobot <gobot@golang.org>
Reviewed-by: Brad Fitzpatrick <bradfitz@golang.org>
---

diff --git a/src/cmd/link/internal/ld/lib.go b/src/cmd/link/internal/ld/lib.go
index 0f3b46d972..b69e3a6018 100644
--- a/src/cmd/link/internal/ld/lib.go
+++ b/src/cmd/link/internal/ld/lib.go
@@ -1260,7 +1260,9 @@ func (l *Link) hostlink() {
 
 	if out, err := exec.Command(argv[0], argv[1:]...).CombinedOutput(); err != nil {
 		Exitf("running %s failed: %v\n%s", argv[0], err, out)
-	} else if l.Debugvlog != 0 && len(out) > 0 {
+	} else if len(out) > 0 {
+		// always print external output even if the command is successful, so that we don't
+		// swallow linker warnings (see https://golang.org/issue/17935).
 		l.Logf("%s", out)
 	}