From: Robert Griesemer Date: Wed, 27 Mar 2019 22:50:36 +0000 (-0700) Subject: math/big: temporarily disable buggy shlVU assembly for arm64 X-Git-Tag: go1.13beta1~876 X-Git-Url: http://www.git.cypherpunks.su/?a=commitdiff_plain;h=4dce6dbb1e3269211e9dafb6a406035696993574;p=gostls13.git math/big: temporarily disable buggy shlVU assembly for arm64 This addresses the failures we have seen in #31084. The correct fix is to find the actual bug in the assembly code. Updates #31084. Change-Id: I437780c53d0c4423d742e2e3b650b899ce845372 Reviewed-on: https://go-review.googlesource.com/c/go/+/169721 Run-TryBot: Robert Griesemer Reviewed-by: Brad Fitzpatrick TryBot-Result: Gobot Gobot --- diff --git a/src/math/big/arith_arm64.s b/src/math/big/arith_arm64.s index eebdf59fb2..bb23751ba3 100644 --- a/src/math/big/arith_arm64.s +++ b/src/math/big/arith_arm64.s @@ -197,6 +197,10 @@ len0: // func shlVU(z, x []Word, s uint) (c Word) TEXT ·shlVU(SB),NOSPLIT,$0 + // Disable assembly for now - it is subtly incorrect. + // See #31084 for a test that fails using this code. + B ·shlVU_g(SB) + MOVD z+0(FP), R0 MOVD z_len+8(FP), R1 MOVD x+24(FP), R2