From: Rob Pike Date: Wed, 27 Mar 2013 00:32:22 +0000 (-0700) Subject: lib/codereview/codereview.py: fix crash when hg gofmt has no files X-Git-Tag: go1.1rc2~316 X-Git-Url: http://www.git.cypherpunks.su/?a=commitdiff_plain;h=50231fa19f7c88834edd95836dca95267ef8bb4f;p=gostls13.git lib/codereview/codereview.py: fix crash when hg gofmt has no files The gofmt function was returning a string, which isn't the right type. Three cheers for dynamic typing. R=golang-dev, bradfitz CC=golang-dev https://golang.org/cl/7917044 --- diff --git a/lib/codereview/codereview.py b/lib/codereview/codereview.py index 11766fcb23..f839263c55 100644 --- a/lib/codereview/codereview.py +++ b/lib/codereview/codereview.py @@ -1762,7 +1762,8 @@ def gofmt(ui, repo, *pats, **opts): files = ChangedExistingFiles(ui, repo, pats, opts) files = gofmt_required(files) if not files: - return "no modified go files" + ui.status("no modified go files\n") + return cwd = os.getcwd() files = [RelativePath(repo.root + '/' + f, cwd) for f in files] try: