From: Russ Cox <rsc@golang.org>
Date: Sat, 1 Sep 2012 14:34:58 +0000 (-0400)
Subject: cmd/go: be clear that import loops are bad
X-Git-Tag: go1.1rc2~2545
X-Git-Url: http://www.git.cypherpunks.su/?a=commitdiff_plain;h=508bfda6d3dd40e2906fb6538b5e4db0ba129645;p=gostls13.git

cmd/go: be clear that import loops are bad

There was mail on golang-nuts a few weeks ago
from someone who understood the message perfectly
and knew he had a cyclic dependency but assumed
that Go, like Python or Java, was supposed to handle it.

R=golang-dev, bradfitz, dave
CC=golang-dev
https://golang.org/cl/6488069
---

diff --git a/src/cmd/go/pkg.go b/src/cmd/go/pkg.go
index 62533b3e01..c9c4e2d779 100644
--- a/src/cmd/go/pkg.go
+++ b/src/cmd/go/pkg.go
@@ -250,7 +250,7 @@ func reusePackage(p *Package, stk *importStack) *Package {
 		if p.Error == nil {
 			p.Error = &PackageError{
 				ImportStack: stk.copy(),
-				Err:         "import loop",
+				Err:         "import cycle not allowed",
 			}
 		}
 		p.Incomplete = true