From: Ian Lance Taylor <iant@golang.org>
Date: Tue, 4 Apr 2023 21:43:46 +0000 (-0700)
Subject: cmd/dist: skip static linking tests for linux boringcrypto
X-Git-Tag: go1.21rc1~1038
X-Git-Url: http://www.git.cypherpunks.su/?a=commitdiff_plain;h=508f445a28b08ed8c881572652c47139e669c19d;p=gostls13.git

cmd/dist: skip static linking tests for linux boringcrypto

Otherwise we get warnings from the C linker.

Fixes #59422

Change-Id: I61843dbe5245da0185b0f23dc4b774767fffed40
Reviewed-on: https://go-review.googlesource.com/c/go/+/482315
TryBot-Result: Gopher Robot <gobot@golang.org>
Reviewed-by: Ian Lance Taylor <iant@google.com>
Reviewed-by: Dmitri Shuralyov <dmitshur@google.com>
Run-TryBot: Ian Lance Taylor <iant@golang.org>
Auto-Submit: Ian Lance Taylor <iant@golang.org>
Reviewed-by: Dmitri Shuralyov <dmitshur@golang.org>
---

diff --git a/src/cmd/dist/test.go b/src/cmd/dist/test.go
index a52457efcc..fa03068350 100644
--- a/src/cmd/dist/test.go
+++ b/src/cmd/dist/test.go
@@ -1266,6 +1266,17 @@ func (t *tester) registerCgoTests() {
 				}
 			}
 
+			// Doing a static link with boringcrypto gets
+			// a C linker warning on Linux.
+			// in function `bio_ip_and_port_to_socket_and_addr':
+			// warning: Using 'getaddrinfo' in statically linked applications requires at runtime the shared libraries from the glibc version used for linking
+			if staticCheck.pre == nil && goos == "linux" && strings.Contains(goexperiment, "boringcrypto") {
+				staticCheck.pre = func(*distTest) bool {
+					fmt.Println("skipping static linking check on Linux when using boringcrypto to avoid C linker warning about getaddrinfo")
+					return false
+				}
+			}
+
 			// Static linking tests
 			if goos != "android" && p != "netbsd/arm" {
 				// TODO(#56629): Why does this fail on netbsd-arm?