From: Russ Cox Date: Mon, 8 Sep 2014 03:40:27 +0000 (-0400) Subject: net/http/httptest: delete TestIssue7264 X-Git-Tag: go1.4beta1~493 X-Git-Url: http://www.git.cypherpunks.su/?a=commitdiff_plain;h=50fc0f1af626c57acaae2eb63781a6d76d7de9f0;p=gostls13.git net/http/httptest: delete TestIssue7264 Now it's failing on Windows: panic: httptest: failed to listen on a port: listen tcp 127.0.0.1:0: listen: An operation on a socket could not be performed because the system lacked sufficient buffer space or because a queue was full. Since we can't seem to understand what the test is trying to test, and because it is causing problems on multiple systems, delete it. Fixes #7264. TBR=bradfitz CC=brainman, golang-codereviews https://golang.org/cl/141210043 --- diff --git a/src/pkg/net/http/httptest/server_test.go b/src/pkg/net/http/httptest/server_test.go index a1c38c50ba..500a9f0b80 100644 --- a/src/pkg/net/http/httptest/server_test.go +++ b/src/pkg/net/http/httptest/server_test.go @@ -8,7 +8,6 @@ import ( "io/ioutil" "net/http" "testing" - "time" ) func TestServer(t *testing.T) { @@ -28,25 +27,3 @@ func TestServer(t *testing.T) { t.Errorf("got %q, want hello", string(got)) } } - -func TestIssue7264(t *testing.T) { - for i := 0; i < 1000; i++ { - func() { - ts := NewServer(http.HandlerFunc(func(w http.ResponseWriter, r *http.Request) {})) - defer ts.Close() - tr := &http.Transport{ - ResponseHeaderTimeout: time.Nanosecond, - } - defer tr.CloseIdleConnections() - c := &http.Client{Transport: tr} - res, err := c.Get(ts.URL) - // err can be non-nil here. - // If the client writes the header and then immediately observes - // the timeout and closes the connection, the server might never - // have gotten a chance to send a response. That's okay. - if err == nil { - res.Body.Close() - } - }() - } -}