From: Felix Geisendörfer <felix.geisendoerfer@datadoghq.com>
Date: Tue, 23 May 2023 10:35:48 +0000 (+0200)
Subject: runtime/metrics: add /gc/scan/total:bytes
X-Git-Tag: go1.21rc1~329
X-Git-Url: http://www.git.cypherpunks.su/?a=commitdiff_plain;h=5124371c1c7d6e2f5c8ebf821fdd07ea71d564c7;p=gostls13.git

runtime/metrics: add /gc/scan/total:bytes

For #56857

Change-Id: I10dbc5db506c95b7578c2b6baf051a351f68bb2a
Reviewed-on: https://go-review.googlesource.com/c/go/+/497576
TryBot-Result: Gopher Robot <gobot@golang.org>
Reviewed-by: David Chase <drchase@google.com>
Reviewed-by: Michael Knyszek <mknyszek@google.com>
Run-TryBot: Felix Geisendörfer <felix.geisendoerfer@datadoghq.com>
Auto-Submit: Michael Knyszek <mknyszek@google.com>
---

diff --git a/src/runtime/metrics.go b/src/runtime/metrics.go
index 356d21ae7d..4c51efaad9 100644
--- a/src/runtime/metrics.go
+++ b/src/runtime/metrics.go
@@ -201,6 +201,12 @@ func initMetrics() {
 				out.scalar = gcController.heapScan.Load()
 			},
 		},
+		"/gc/scan/total:bytes": {
+			compute: func(in *statAggregate, out *metricValue) {
+				out.kind = metricKindUint64
+				out.scalar = gcController.globalsScan.Load() + gcController.heapScan.Load() + gcController.lastStackScan.Load()
+			},
+		},
 		"/gc/heap/allocs-by-size:bytes": {
 			deps: makeStatDepSet(heapStatsDep),
 			compute: func(in *statAggregate, out *metricValue) {
diff --git a/src/runtime/metrics/description.go b/src/runtime/metrics/description.go
index ac6f437075..b34ffe405d 100644
--- a/src/runtime/metrics/description.go
+++ b/src/runtime/metrics/description.go
@@ -309,6 +309,11 @@ var allDesc = []Description{
 		Description: "The number of bytes of stack that were scanned last GC cycle.",
 		Kind:        KindUint64,
 	},
+	{
+		Name:        "/gc/scan/total:bytes",
+		Description: "The total amount space that is scannable. Sum of all metrics in /gc/scan.",
+		Kind:        KindUint64,
+	},
 	{
 		Name:        "/gc/stack/starting-size:bytes",
 		Description: "The stack size of new goroutines.",
diff --git a/src/runtime/metrics/doc.go b/src/runtime/metrics/doc.go
index 15fba2b5d4..44e2676ac5 100644
--- a/src/runtime/metrics/doc.go
+++ b/src/runtime/metrics/doc.go
@@ -225,6 +225,10 @@ Below is the full list of supported metrics, ordered lexicographically.
 	/gc/scan/stack:bytes
 		The number of bytes of stack that were scanned last GC cycle.
 
+	/gc/scan/total:bytes
+		The total amount space that is scannable. Sum of all metrics in
+		/gc/scan.
+
 	/gc/stack/starting-size:bytes
 		The stack size of new goroutines.