From: Bryan C. Mills <bcmills@google.com>
Date: Fri, 10 Mar 2023 19:21:01 +0000 (-0500)
Subject: os: skip TestExecutableDeleted earlier when 'go build' is not supported
X-Git-Tag: go1.21rc1~1311
X-Git-Url: http://www.git.cypherpunks.su/?a=commitdiff_plain;h=53c91f9205e2b61d972ab1eaf5c9716aabe10306;p=gostls13.git

os: skip TestExecutableDeleted earlier when 'go build' is not supported

The test unconditionally calls testenv.GoToolPath, which will skip the
test anyway. Moving the skip earlier gets this test out of goroutine
dumps if the test process fails or times out, making it easier to
diagnose failures in the remaining tests.

Change-Id: Ibd39546708a83b6f15616b2c4ae7af420e2401f0
Reviewed-on: https://go-review.googlesource.com/c/go/+/475455
TryBot-Result: Gopher Robot <gobot@golang.org>
Auto-Submit: Bryan Mills <bcmills@google.com>
Run-TryBot: Bryan Mills <bcmills@google.com>
Reviewed-by: Ian Lance Taylor <iant@google.com>
---

diff --git a/src/os/executable_test.go b/src/os/executable_test.go
index 8d1794d340..c835bb436b 100644
--- a/src/os/executable_test.go
+++ b/src/os/executable_test.go
@@ -89,7 +89,7 @@ func init() {
 }
 
 func TestExecutableDeleted(t *testing.T) {
-	testenv.MustHaveExec(t)
+	testenv.MustHaveGoBuild(t)
 	switch runtime.GOOS {
 	case "windows", "plan9":
 		t.Skipf("%v does not support deleting running binary", runtime.GOOS)