From: Cherry Zhang <cherryyz@google.com>
Date: Thu, 31 Oct 2019 20:08:56 +0000 (-0400)
Subject: [dev.link] all: reenable cgo internal linking tests
X-Git-Tag: go1.14beta1~292^2^2~8
X-Git-Url: http://www.git.cypherpunks.su/?a=commitdiff_plain;h=5597e3d38968beb41f78971d523aef0a49605410;p=gostls13.git

[dev.link] all: reenable cgo internal linking tests

Cgo internal linking was disabled when switching to new object
files. Reeanble the tests, as they get supported.

Change-Id: I11d2ac8785cce73f3a42f6935c10d9f067bc90a4
Reviewed-on: https://go-review.googlesource.com/c/go/+/204520
Reviewed-by: Than McIntosh <thanm@google.com>
---

diff --git a/src/cmd/dist/test.go b/src/cmd/dist/test.go
index eeddd9474c..cc54554a1d 100644
--- a/src/cmd/dist/test.go
+++ b/src/cmd/dist/test.go
@@ -904,9 +904,6 @@ func (t *tester) extLink() bool {
 }
 
 func (t *tester) internalLink() bool {
-	if true { // appease vet...
-		return false // TODO: newobj
-	}
 	if gohostos == "dragonfly" {
 		// linkmode=internal fails on dragonfly since errno is a TLS relocation.
 		return false
diff --git a/src/cmd/nm/nm_cgo_test.go b/src/cmd/nm/nm_cgo_test.go
index dde24a0b72..9a257e0ed2 100644
--- a/src/cmd/nm/nm_cgo_test.go
+++ b/src/cmd/nm/nm_cgo_test.go
@@ -37,7 +37,7 @@ func canInternalLink() bool {
 }
 
 func TestInternalLinkerCgoExec(t *testing.T) {
-	if !canInternalLink() || true { // TODO: newobj
+	if !canInternalLink() {
 		t.Skip("skipping; internal linking is not supported")
 	}
 	testGoExec(t, true, false)
diff --git a/src/debug/pe/file_cgo_test.go b/src/debug/pe/file_cgo_test.go
index e89894953b..739671d73f 100644
--- a/src/debug/pe/file_cgo_test.go
+++ b/src/debug/pe/file_cgo_test.go
@@ -23,7 +23,6 @@ func TestDefaultLinkerDWARF(t *testing.T) {
 }
 
 func TestInternalLinkerDWARF(t *testing.T) {
-	t.Skip("TODO: newobj")
 	testCgoDWARF(t, linkCgoInternal)
 }