From: Cherry Zhang <cherryyz@google.com>
Date: Fri, 10 Jul 2020 22:53:12 +0000 (-0400)
Subject: [dev.link] cmd/link: dump symbol info on crash under -v
X-Git-Tag: go1.16beta1~1378^2~54
X-Git-Url: http://www.git.cypherpunks.su/?a=commitdiff_plain;h=5698ec36a86afcba0f7fe06e97e4cd5deaabe3f9;p=gostls13.git

[dev.link] cmd/link: dump symbol info on crash under -v

If the linker panics, it usually helps dumping all symbols'
information for debugging. Do it under -v.

Change-Id: I66f9e32a0133e763a631f17a218dcdc805c5df2f
Reviewed-on: https://go-review.googlesource.com/c/go/+/242078
Run-TryBot: Cherry Zhang <cherryyz@google.com>
TryBot-Result: Gobot Gobot <gobot@golang.org>
Reviewed-by: Jeremy Faller <jeremy@golang.org>
---

diff --git a/src/cmd/link/internal/ld/main.go b/src/cmd/link/internal/ld/main.go
index d9ff359b35..c40e932d8b 100644
--- a/src/cmd/link/internal/ld/main.go
+++ b/src/cmd/link/internal/ld/main.go
@@ -136,6 +136,11 @@ func Main(arch *sys.Arch, theArch Arch) {
 
 	objabi.Flagparse(usage)
 
+	if ctxt.Debugvlog > 0 {
+		// dump symbol info on crash
+		defer func() { ctxt.loader.Dump() }()
+	}
+
 	switch *flagHeadType {
 	case "":
 	case "windowsgui":